Skip to content

nginx-module.eclass: General overhaul

Adrian Schollmeyer requested to merge nginx-module-overhaul into master

This commit does a small overhaul of this eclass to bring it up to date with current EAPIs, improve some of the descriptions and make the code more dynamic.

  • Variables NGINX_PV and MODULE_PV are made pre-inherit vars with default values. This allows packagers to override the values if needed (e.g. if the module upstream's versioning does not comply with Gentoo's versioning scheme).
  • A new variable MODULE_SOURCE is introduced to allow overwriting the source directory of modules, in case upstream's source tarballs don't extract into a directory {PN}-{MODULE_PV}. This also removes the need to explicitly specify {PN}-{MODULE_PV} in all the places the module source directory is referenced.
  • Various descriptions are updated to make them more readable and/or fix typos.
  • EAPI 8 support is added.
  • Some shell expressions are made more robust as indicated by shellcheck.
  • Variables defined in functions are set to local where possible.
  • ${S} is dropped from do* calls in src_install, since they are not needed.

Signed-off-by: Adrian 'nex' Schollmeyer adrian.schollmeyer@fem.tu-ilmenau.de

Merge request reports